Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 513f6e7095e6a8730bfd06084c8b3e68a974e856 https://github.com/WebKit/WebKit/commit/513f6e7095e6a8730bfd06084c8b3e68a974e856 Author: Chris Dumez <cdu...@apple.com> Date: 2024-05-22 (Wed, 22 May 2024)
Changed paths: M Source/WTF/wtf/text/Base64.h M Source/WebCore/Modules/identity/DigitalCredential.cpp M Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp M Source/WebCore/Modules/websockets/WebSocketHandshake.cpp M Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp M Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp M Source/WebCore/inspector/DOMPatchSupport.cpp M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp M Source/WebCore/inspector/agents/InspectorPageAgent.cpp M Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm M Source/WebCore/page/Base64Utilities.cpp M Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp M Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp M Source/WebCore/storage/StorageUtilities.cpp M Source/WebCore/workers/service/server/SWScriptStorage.cpp M Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp M Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm M Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm M Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm M Tools/TestWebKitAPI/cocoa/HTTPServer.mm Log Message: ----------- Update base64EncodeToString() / base64URLEncodeToString() overloads https://bugs.webkit.org/show_bug.cgi?id=274503 Reviewed by Sihui Liu and Darin Adler. Update base64EncodeToString() / base64URLEncodeToString() overloads to force the call sites to provide either a `std::span<const std::byte>` or a `std::span<const uint8_t>`. This is a step towards our broader std::span adoption and using more consistent typing to represent bytes. * Source/WTF/wtf/text/Base64.h: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::DigitalCredential::DigitalCredential): * Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp: (WebCore::PublicKeyCredential::PublicKeyCredential): * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp: (WebCore::buildClientDataJson): * Source/WebCore/Modules/websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::getExpectedWebSocketAccept): * Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp: (WebCore::CryptoKeyEC::platformAddFieldElements const): * Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp: (WebCore::CryptoKeyEC::platformAddFieldElements const): * Source/WebCore/inspector/DOMPatchSupport.cpp: (WebCore::DOMPatchSupport::createDigest): * Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::getSerializedCertificate): * Source/WebCore/inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::archive): * Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm: (WebCore::PrivateClickMeasurement::calculateAndUpdateUnlinkableToken): (WebCore::PrivateClickMeasurement::calculateAndUpdateSecretToken): * Source/WebCore/page/Base64Utilities.cpp: (WebCore::Base64Utilities::btoa): * Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp: (WebCore::extractKeyidsFromCencInitData): (WebCore::CDMInstanceSessionClearKey::removeSessionData): * Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp: (WebCore::createUniqueFontName): * Source/WebCore/platform/network/soup/SoupNetworkSession.cpp: (WebCore::HostTLSCertificateSet::computeCertificateHash): * Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::mediaControlsBase64StringForIconNameAndType): * Source/WebCore/storage/StorageUtilities.cpp: (WebCore::StorageUtilities::encodeSecurityOriginForFileName): * Source/WebCore/workers/service/server/SWScriptStorage.cpp: (WebCore::SWScriptStorage::sha2Hash const): * Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp: (WebKit::PrivateClickMeasurementManager::fireConversionRequest): * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::encode): * Source/WebKit/UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp: (WebKit::base64EncodedPNGData): * Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: (WebKit::base64EncodedPNGData): * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticatorInternal::produceHashSet): (WebKit::LocalAuthenticator::makeCredential): (WebKit::LocalAuthenticator::getAssertion): * Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm: (WebKit::MockLocalConnection::filterResponses const): * Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm: (TestWebKitAPI::TEST(PrivateClickMeasurement, ValidBlindedSecret)): * Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm: (TestWebKitAPI::signUnlinkableTokenAndSendSecretToken): * Tools/TestWebKitAPI/cocoa/HTTPServer.mm: (TestWebKitAPI::Connection::webSocketHandshake): Canonical link: https://commits.webkit.org/279138@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes