Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ddb740bdea7c4f3d92623dea99d7771f79c5a21
      
https://github.com/WebKit/WebKit/commit/6ddb740bdea7c4f3d92623dea99d7771f79c5a21
  Author: Wenson Hsieh <wenson_hs...@apple.com>
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
    M Source/WebCore/page/ElementTargetingController.cpp
    M Source/WebCore/page/ElementTargetingController.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm

  Log Message:
  -----------
  [Remote Inspection] Right click > Toggle Visibility sometimes fails to reveal 
hidden elements
https://bugs.webkit.org/show_bug.cgi?id=274586

Reviewed by Aditya Keerthi.

Make a couple of minor adjustments to undo initial visibility adjustment rules 
when Web Inspector
resets "Toggle Visibility" state for targeted elements.

* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::ElementTargetingController::adjustVisibilityInRepeatedlyTargetedRegions):
(WebCore::ElementTargetingController::reset):
(WebCore::ElementTargetingController::resetVisibilityAdjustments):
* Source/WebCore/page/ElementTargetingController.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm:
(-[_WKTargetedElementInfo debugDescription]):

Also, add a `-debugDescription` to make debug logging more useful.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm:
(TestWebKitAPI::TEST(ElementTargeting, RequestElementsFromSelectors)):

Canonical link: https://commits.webkit.org/279213@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to