Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35683740872fdff569e5b4f2ceb010b3838c7087 https://github.com/WebKit/WebKit/commit/35683740872fdff569e5b4f2ceb010b3838c7087 Author: Elliott Williams <e...@apple.com> Date: 2024-05-24 (Fri, 24 May 2024)
Changed paths: M Source/WebKit/MigratedHeaders-input.xcfilelist M Source/WebKit/MigratedHeaders-output.xcfilelist M Source/WebKit/Modules/OSX_Private.modulemap M Source/WebKit/Modules/iOS_Private.modulemap M Source/WebKitLegacy/PlatformMac.cmake M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj M Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig R Source/WebKitLegacy/mac/Misc/NSURLDownloadSPI.h M Source/WebKitLegacy/mac/Misc/WebDownload.h Log Message: ----------- Remove NSURLDownloadSPI.h https://bugs.webkit.org/show_bug.cgi?id=274675 rdar://problem/128695608 Reviewed by Alexey Proskuryakov. It was marked as a private header due to a single include in WebDownload.h. It's weird to have an SPI header installed to the SDK, so instead, just inline the declarations we need into WebDownload.h. Additionally, import NSURLDownload.h when building for Mac Catalyst. The preprocessor check was incorrectly assuming that it didn't have the header available, because Catalyst is a TARGET_OS_IPHONE target despite using the macOS SDK. * Source/WebKit/MigratedHeaders-input.xcfilelist: * Source/WebKit/MigratedHeaders-output.xcfilelist: * Source/WebKit/Modules/OSX_Private.modulemap: * Source/WebKit/Modules/iOS_Private.modulemap: * Source/WebKitLegacy/PlatformMac.cmake: * Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj: * Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig: * Source/WebKitLegacy/mac/Misc/NSURLDownloadSPI.h: Removed. * Source/WebKitLegacy/mac/Misc/WebDownload.h: Inline the NSURLDownload declarations needed in public embedded builds. Declare NSURLDownload as visibility("hidden") to satisfy TAPI. Canonical link: https://commits.webkit.org/279303@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes