Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e50a242c2c4be6fdd0ed66f8fd9685eaf1d307b5
https://github.com/WebKit/WebKit/commit/e50a242c2c4be6fdd0ed66f8fd9685eaf1d307b5
Author: Alan Baradlay <za...@apple.com>
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
A LayoutTests/fast/inline/floating-dialog-becomes-modal-crash-expected.txt
A LayoutTests/fast/inline/floating-dialog-becomes-modal-crash.html
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
Log Message:
-----------
[IFC] LineLayout::containing may return incorrect block container for <dialog>
https://bugs.webkit.org/show_bug.cgi?id=275162
<rdar://129232519>
Reviewed by Antti Koivisto.
1. properties that we use to decide whether a renderer is
"isInTopLayerOrBackdrop" are set on associated element before applying the most
recent style (RenderElement::setStyle).
2. RenderObject::containingBlock() consults isInTopLayerOrBackdrop to see
whether it should just simply return the ICB.
When containingBlock() is called from _styleWillChange_, while the expected
behavior is to get a containing block based on current (old) style, in case of
"isInTopLayerOrBackdrop"
boxes, containingBlock() returns a box already taking these new "properties"
into account.
* LayoutTests/fast/inline/floating-dialog-becomes-modal-crash-expected.txt:
Added.
* LayoutTests/fast/inline/floating-dialog-becomes-modal-crash.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::containing):
Canonical link: https://commits.webkit.org/279747@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
