Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c16f89f981dd428c469acdcadca90666bf0e67f
      
https://github.com/WebKit/WebKit/commit/8c16f89f981dd428c469acdcadca90666bf0e67f
  Author: Tadeu Zagallo <tzaga...@apple.com>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/WGSL.cpp
    A Source/WebGPU/WGSL/tests/valid/array-vec3.wgsl

  Log Message:
  -----------
  [WGSL] Cannot access fields of PackedVec3
https://bugs.webkit.org/show_bug.cgi?id=275175
rdar://129052933

Reviewed by Mike Wyrzykowski.

The current implementation of PackedVec3 wraps a packed_vec<T, 3>, but it 
doesn't
provide any means to access the components of the vector. Change it so it 
matches
the vec/packed_vec interface by having x/y/z members and implementing a 
subscript
operator.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::getPacking):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::prepareImpl):

Canonical link: https://commits.webkit.org/279808@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to