Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d48e67ce96f458d90843afa21b9bb56bdbb964ef
https://github.com/WebKit/WebKit/commit/d48e67ce96f458d90843afa21b9bb56bdbb964ef
Author: Philippe Normand <ph...@igalia.com>
Date: 2024-06-14 (Fri, 14 Jun 2024)
Changed paths:
M
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
M
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
Log Message:
-----------
[GStreamer] Duplicate WebCore log messages due to observing the document
logger multiple times
https://bugs.webkit.org/show_bug.cgi?id=275396
Reviewed by Xabier Rodriguez-Calvar.
Because both the PeerConnection and HTMLMediaElement rely on the same logger
instance (the one
created by the document), a page containing more than one PeerConnection and/or
more than one Media
element would emit duplicate logs because we were adding multiple log observers
to the same logger.
Also we now filter log message by their channel name before dispatching them to
the GStreamer
logging system.
Thanks to Carlos Bentzen for the report.
*
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::webrtcLogObserverSingleton):
(WebCore::GStreamerPeerConnectionBackend::GStreamerPeerConnectionBackend):
(WebCore::GStreamerPeerConnectionBackend::~GStreamerPeerConnectionBackend):
(WebCore::GStreamerPeerConnectionBackend::didLogMessage): Deleted.
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h:
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::WebCoreLogObserver::didLogMessage):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::WebCoreLogObserver::addWatch):
(WebCore::WebCoreLogObserver::removeWatch):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaLogObserverSingleton):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::mediaPlayerWillBeDestroyed):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::didLogMessage): Deleted.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Canonical link: https://commits.webkit.org/280007@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
