Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 635b3690eaea76a04a790a5ca8b8eb99d7191f0d
      
https://github.com/WebKit/WebKit/commit/635b3690eaea76a04a790a5ca8b8eb99d7191f0d
  Author: Carlos Garcia Campos <cgar...@igalia.com>
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
    M Source/WebKit/WPEPlatform/CMakeLists.txt
    M Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp
    M Source/WebKit/WPEPlatform/wpe/WPEInputMethodContext.cpp
    A Source/WebKit/WPEPlatform/wpe/WPEInputMethodContextNone.cpp
    A Source/WebKit/WPEPlatform/wpe/WPEInputMethodContextNone.h
    M Source/WebKit/WPEPlatform/wpe/WPEView.cpp

  Log Message:
  -----------
  [WPE] WPE Platform: add none IM context implementation as fallback
https://bugs.webkit.org/show_bug.cgi?id=275480

Reviewed by Nikolas Zimmermann.

We don't want object new methods that can return nullptr, so better
have a None implementation used as fallback for platforms not implementing IME.
Also make create_view mandatory for the same reason, but in this case
all platform implementations are expected to implement WPEView.

* Source/WebKit/WPEPlatform/CMakeLists.txt:
* Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp:
(wpeDisplayCreateView):
(wpeDisplayCreateInputMethodContext):
* Source/WebKit/WPEPlatform/wpe/WPEInputMethodContext.cpp:
* Source/WebKit/WPEPlatform/wpe/WPEInputMethodContextNone.cpp: Added.
(wpeInputMethodContextNoneGetPreeditString):
(wpe_input_method_context_none_class_init):
(wpeInputMethodContextNoneNew):
* Source/WebKit/WPEPlatform/wpe/WPEInputMethodContextNone.h: Added.
* Source/WebKit/WPEPlatform/wpe/WPEView.cpp:

Canonical link: https://commits.webkit.org/280009@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to