Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b9d301c88a3e3a6e8f98ca6f940d8e4e04f7d9e https://github.com/WebKit/WebKit/commit/9b9d301c88a3e3a6e8f98ca6f940d8e4e04f7d9e Author: Andres Gonzalez <andresg...@apple.com> Date: 2024-06-20 (Thu, 20 Jun 2024)
Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm Log Message: ----------- AX: AXObjectCache::postTextReplacementPlatformNotificationForTextControl takes an HTMLTextFormControlElement parameter unnecessarily. https://bugs.webkit.org/show_bug.cgi?id=275688 <rdar://problem/130206150> Reviewed by Tyler Wilcock. Eliminating this extra parameter that was used only on Mac, makes possible to clean up the code to create an AXTextMarker for the first position in the control and remove the corresponding wrapper method. This change is a precursor to further changes to remove the Node* from the AXTextMarkerData structure. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::postTextReplacementNotificationForTextControl): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp: (WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl): * Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm: (WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl): * Source/WebCore/accessibility/mac/AXObjectCacheMac.mm: (WebCore::addTextMarkerForVisiblePosition): (WebCore::addFirstTextMarker): (WebCore::textReplacementChangeDictionary): (WebCore::AXObjectCache::postTextReplacementPlatformNotification): (WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl): (WebCore::addTextMarkerFor): Deleted. * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h: * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper textMarkerForFirstPositionInTextControl:]): Deleted. Canonical link: https://commits.webkit.org/280224@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes