Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 426186a23c4afc5565407d381766d9cfb9620156
https://github.com/WebKit/WebKit/commit/426186a23c4afc5565407d381766d9cfb9620156
Author: Fujii Hironori <[email protected]>
Date: 2024-07-05 (Fri, 05 Jul 2024)
Changed paths:
M Tools/CISupport/kill-old-processes
M Tools/Scripts/webkitpy/port/win.py
M Tools/WebKitTestRunner/PlatformWin.cmake
M Tools/WebKitTestRunner/win/TestControllerWin.cpp
A Tools/WebKitTestRunner/win/WebKitTestRunnerWS.cpp
Log Message:
-----------
[Win][WebKitTestRunner] Use CreateWindowStation to have an isolated clipboard
https://bugs.webkit.org/show_bug.cgi?id=224919
Reviewed by Don Olmstead.
Layout tests using a clipboard are flaky because multiple instances of
WebKitTestRunner are simultaneously using a single clipboard.
<https://commits.webkit.org/184203@main> changed DumpRenderTree to use
CreateWindowStation to have a isolated clipboard. However, the exactly
same approach can't be applied to WebKitTestRunner due to the
multi-process architecture.
Added a new program WebKitTestRunnerWS.exe to create a non-interactive
window station and a hidden desktop and execute WebKitTestRunner.exe
in it.
I confirmed the following scenarios:
1. run-webkit-tests collects crash logs of WebKitTestRunner for crash tests
2. run-webkit-tests kills all child processes of WebKitTestRunnerWS for timeout
tests
3. run-webkit-tests --show-window shows windows
* Tools/CISupport/kill-old-processes:
(main):
* Tools/Scripts/webkitpy/port/win.py:
(WinPort.driver_name):
* Tools/WebKitTestRunner/PlatformWin.cmake:
* Tools/WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::exceptionFilter):
* Tools/WebKitTestRunner/win/WebKitTestRunnerWS.cpp: Added.
(replace):
(containsShowWindowOption):
(wmain):
Canonical link: https://commits.webkit.org/280706@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
