Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cfba0b14d62853e5eba2ce72f1cdf85d93ea2fa1
https://github.com/WebKit/WebKit/commit/cfba0b14d62853e5eba2ce72f1cdf85d93ea2fa1
Author: Alan Baradlay <za...@apple.com>
Date: 2024-07-11 (Thu, 11 Jul 2024)
Changed paths:
A LayoutTests/fast/multicol/line-offset-after-widow-adjustment-expected.html
A LayoutTests/fast/multicol/line-offset-after-widow-adjustment.html
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.h
Log Message:
-----------
[Pagination] Huge vertical space on some books pages with widows
https://bugs.webkit.org/show_bug.cgi?id=276446
<rdar://130783404>
Reviewed by Antti Koivisto.
We use _accumulated_ offset to restart partial inline layout to deal with
widows/orphans
which makes the start position of the "new content" incorrect when we arrive to
this windows/orphans restart through multiple pages.
The fix is to keep track of the _actual_ offset where the new content is
supposed to start taking widows/orphans into account.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::adjustContentForPagination):
* Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::computeAdjustmentsForPagination):
* Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.h:
Canonical link: https://commits.webkit.org/280856@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
