Title: [111086] trunk/Source/WebCore
- Revision
- 111086
- Author
- aba...@webkit.org
- Date
- 2012-03-16 16:41:23 -0700 (Fri, 16 Mar 2012)
Log Message
remove-body-during-body-replacement2.html is triggering crashes on all platforms
https://bugs.webkit.org/show_bug.cgi?id=81374
Reviewed by Eric Seidel.
When overriding disconnectFrame, we need to call the base class version
of the method so that it can clear the m_frame pointer.
Tests: This patch fixes a large number of crashes in tests.
* notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::disconnectFrame):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (111085 => 111086)
--- trunk/Source/WebCore/ChangeLog 2012-03-16 23:27:03 UTC (rev 111085)
+++ trunk/Source/WebCore/ChangeLog 2012-03-16 23:41:23 UTC (rev 111086)
@@ -1,3 +1,18 @@
+2012-03-16 Adam Barth <aba...@webkit.org>
+
+ remove-body-during-body-replacement2.html is triggering crashes on all platforms
+ https://bugs.webkit.org/show_bug.cgi?id=81374
+
+ Reviewed by Eric Seidel.
+
+ When overriding disconnectFrame, we need to call the base class version
+ of the method so that it can clear the m_frame pointer.
+
+ Tests: This patch fixes a large number of crashes in tests.
+
+ * notifications/DOMWindowNotifications.cpp:
+ (WebCore::DOMWindowNotifications::disconnectFrame):
+
2012-03-16 Leo Yang <leo.y...@torchmobile.com.cn>
[BlackBerry] Upstream the BlackBerry change to platform/Widget.h
Modified: trunk/Source/WebCore/notifications/DOMWindowNotifications.cpp (111085 => 111086)
--- trunk/Source/WebCore/notifications/DOMWindowNotifications.cpp 2012-03-16 23:27:03 UTC (rev 111085)
+++ trunk/Source/WebCore/notifications/DOMWindowNotifications.cpp 2012-03-16 23:41:23 UTC (rev 111086)
@@ -87,10 +87,13 @@
void DOMWindowNotifications::disconnectFrame()
{
+ // FIXME: We should support keep the old m_notificationCenter so we can support reconnectFrame().
+ // See DOMWindowIndexedDatabase::disconnectFrame() for an example of how to do this.
if (m_notificationCenter) {
m_notificationCenter->disconnectFrame();
m_notificationCenter = 0;
}
+ DOMWindowProperty::disconnectFrame();
}
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
