Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edd20b55060cae41a9447146a25b92cf5e1d155d
      
https://github.com/WebKit/WebKit/commit/edd20b55060cae41a9447146a25b92cf5e1d155d
  Author: Brandon Stewart <brandonstew...@apple.com>
  Date:   2024-07-19 (Fri, 19 Jul 2024)

  Changed paths:
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  -----------
  [css-grid] Split Grid and Masonry Implementation in resolveIntrinsicTrackSizes
https://bugs.webkit.org/show_bug.cgi?id=276831
rdar://problem/132103501

Reviewed by Sammy Gill.

Refactoring work to split up the implementations of resolveIntrinsicTrackSizes
and accumulateIntrinsicSizesForTrack.

Both of these implementations are constantly diverging based on optimizations I
have been working on. The Grid implementation is becoming more confusing to 
follow,
since it often does not need to care about the Masonry pieces.

Also, factored out handleInfinityGrowthLimit since it was just duplicating code 
that
was the exact same across implementations.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrackMasonry):
(WebCore::GridTrackSizingAlgorithm::handleInfinityGrowthLimit):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizes):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizesMasonry):
(WebCore::GridTrackSizingAlgorithm::run):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/281155@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to