Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 52ae7a91d2f17f37196774a206ff481a8d706cbf
https://github.com/WebKit/WebKit/commit/52ae7a91d2f17f37196774a206ff481a8d706cbf
Author: Ahmad Saleem <ahmad.saleem...@gmail.com>
Date: 2024-07-24 (Wed, 24 Jul 2024)
Changed paths:
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerModelObject.cpp
Log Message:
-----------
destroyLayer() should call setHasLayer(false)
https://bugs.webkit.org/show_bug.cgi?id=276996
Reviewed by Simon Fraser.
Merge:
https://github.com/chromium/chromium/commit/515b887cc764eff0fd976bf60efd6dd6fd099ec5
This change synchronize clearing the layer and calling setHasLayer.
The old code would dissociate the two operations to handle clean-ups
during RenderLayer::removeOnlyThisLayer. The dissociation was
introduced to handle bug 25252 (33539@main)
and Eric wasn't sure at the time it was the right solution.
Based on the fact that the tests are still passing, it wasn't.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::removeOnlyThisLayer):
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::destroyLayer):
Canonical link: https://commits.webkit.org/281307@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
