Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b51f69ea01966e72fba76bbd4fd99ab23f90c177 https://github.com/WebKit/WebKit/commit/b51f69ea01966e72fba76bbd4fd99ab23f90c177 Author: Abrar Rahman Protyasha <a_protya...@apple.com> Date: 2024-07-25 (Thu, 25 Jul 2024)
Changed paths: M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h M Source/WebKit/Shared/WebPreferencesDefaultValues.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm Log Message: ----------- [UnifiedPDF] Upstream enablement and platform availability information https://bugs.webkit.org/show_bug.cgi?id=277014 rdar://132413786 Reviewed by Wenson Hsieh and Aditya Keerthi. This commit migrates feature enablement and platform availability information related to UnifiedPDF from WebKitAdditions. We take this opportunity to make a couple of clean ups: - Rename ENABLE_UNIFIED_PDF_BY_DEFAULT to ENABLE_UNIFIED_PDF_AS_PREVIEW since the former was a gross misnomer. This flag is only used to define the feature status. - Move around our declaration of the `-[PDFAction nextActions]` SPI in a way that makes said declaration visible to open source builds. - Build UnifiedPDFTests for all platforms where UnifiedPDF is enabled, not only those where it is enabled by default. Also, configure the test web views in the respective tests appropriately by enabling the UnifiedPDF feature. * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h: * Source/WebKit/Shared/WebPreferencesDefaultValues.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm: (TestWebKitAPI::configurationForWebViewTestingUnifiedPDF): (TestWebKitAPI::TEST(UnifiedPDF, KeyboardScrollingInSinglePageMode)): (TestWebKitAPI::TEST(UnifiedPDF, CopyEditingCommandOnEmptySelectionShouldNotCrash)): Canonical link: https://commits.webkit.org/281365@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes