Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 458d9099e1b061628588569e212c198ba73e7313
      
https://github.com/WebKit/WebKit/commit/458d9099e1b061628588569e212c198ba73e7313
  Author: Fujii Hironori <hironori.fu...@sony.com>
  Date:   2024-07-25 (Thu, 25 Jul 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/port/base.py
    M Tools/Scripts/webkitpy/port/win.py

  Log Message:
  -----------
  [Win] run-webkit-tests creates temporary files in the Windows directory
https://bugs.webkit.org/show_bug.cgi?id=277096

Reviewed by Ross Kirsling.

run-webkit-tests created temporary files in the windows directory
(ie C:\windows) because GetTempPath API returns the directory if certain
environment variables aren't set.
<https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-gettemppathw>
run-webkit-tests should propagate TEMP and TMP environment variables
to WebKitTestRunner.

Moved the code of Windows specific environment variables from
setup_environ_for_server method of the base Port class to one of the
derived WinPort class.

Removed environment_for_api_tests method of WinPort class because
environment_for_api_tests method of the base class calls
setup_environ_for_server method.

* Tools/Scripts/webkitpy/port/base.py:
(Port.setup_environ_for_server):
* Tools/Scripts/webkitpy/port/win.py:
(WinPort.setup_environ_for_server):
(WinPort.setup_crash_log_saving):

Canonical link: https://commits.webkit.org/281384@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to