Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d256e34311ea7f00a85409f2f05be31fb888d35 https://github.com/WebKit/WebKit/commit/4d256e34311ea7f00a85409f2f05be31fb888d35 Author: Simon Fraser <simon.fra...@apple.com> Date: 2024-07-27 (Sat, 27 Jul 2024)
Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/page/InteractionRegion.cpp M Source/WebCore/rendering/PathOperation.cpp M Source/WebCore/rendering/PathOperation.h M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/style/BasicShapes.cpp M Source/WebCore/rendering/style/BasicShapes.h Log Message: ----------- Have BasicShapes return Paths by value, and other cleanup https://bugs.webkit.org/show_bug.cgi?id=277193 rdar://132615912 Reviewed by Tim Nguyen. The primary change here is to have BasicShape::path() return a path by value, not by reference. This allows an implementation to construct a path and return it without having to store it somewhere. Path copies are cheap, because internally they use a DataRef<>. Also make PathOperation::OperationType an enum class named Type, and other whitespace and const cleanup. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::valueForPathOperation): * Source/WebCore/page/InteractionRegion.cpp: (WebCore::interactionRegionForRenderedRegion): * Source/WebCore/rendering/PathOperation.cpp: (WebCore::ReferencePathOperation::ReferencePathOperation): (WebCore::RayPathOperation::getPath const): * Source/WebCore/rendering/PathOperation.h: (WebCore::PathOperation::type const): (WebCore::PathOperation::PathOperation): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::hitTestClipPath const): (WebCore::RenderBox::paintClippingMask): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::willCompositeClipPath const): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateMaskingLayerGeometry): (WebCore::RenderLayerBacking::updateMaskingLayer): * Source/WebCore/rendering/style/BasicShapes.cpp: (WebCore::BasicShapeCircle::pathForCenterCoordinate const): (WebCore::BasicShapeCircle::path const): (WebCore::BasicShapeEllipse::pathForCenterCoordinate const): (WebCore::BasicShapeEllipse::path const): (WebCore::BasicShapeRect::path const): (WebCore::BasicShapeXywh::path const): (WebCore::BasicShapePolygon::path const): (WebCore::BasicShapePath::path const): (WebCore::BasicShapeInset::path const): (WebCore::BasicShapeCircle::path): Deleted. (WebCore::BasicShapeEllipse::path): Deleted. (WebCore::BasicShapeRect::path): Deleted. (WebCore::BasicShapeXywh::path): Deleted. (WebCore::BasicShapePolygon::path): Deleted. (WebCore::BasicShapePath::path): Deleted. (WebCore::BasicShapeInset::path): Deleted. * Source/WebCore/rendering/style/BasicShapes.h: Canonical link: https://commits.webkit.org/281453@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes