Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a3a6d9ef649bd2d35065a76943400e805c93989
      
https://github.com/WebKit/WebKit/commit/9a3a6d9ef649bd2d35065a76943400e805c93989
  Author: Youenn Fablet <[email protected]>
  Date:   2024-07-28 (Sun, 28 Jul 2024)

  Changed paths:
    M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp
    M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.h

  Log Message:
  -----------
  Rename setFrameRateAndZoomWithPreset to applyFrameRateAndZoomWithPreset
rdar://132474156
https://bugs.webkit.org/show_bug.cgi?id=277069

Reviewed by Eric Carlson.

We do the renaming to clarify that two things are happening whhen applying 
constraints:
1. Update the underlying state of the source, done in 
applyFrameRateAndZoomWithPreset.
2. Update the RealtimeMediaSource members related settings.

We also introduce RealtimeVideoCaptureSource::setSizeFrameRateAndZoomForPhoto 
to share more code between going to photo mode and exiting photo mode.

* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:
(WebCore::RealtimeVideoCaptureSource::setSizeFrameRateAndZoom):
(WebCore::RealtimeVideoCaptureSource::setSizeFrameRateAndZoomForPhoto):
(WebCore::RealtimeVideoCaptureSource::takePhoto):
* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::applyFrameRateAndZoomWithPreset):
(WebCore::AVVideoCaptureSource::setFrameRateAndZoomWithPreset): Deleted.
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::applyFrameRateAndZoomWithPreset):
(WebCore::MockRealtimeVideoSource::setFrameRateAndZoomWithPreset): Deleted.
* Source/WebCore/platform/mock/MockRealtimeVideoSource.h:

Canonical link: https://commits.webkit.org/281469@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to