Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 79dc79d2431d64c34080a37b799f42842394df77
https://github.com/WebKit/WebKit/commit/79dc79d2431d64c34080a37b799f42842394df77
Author: Elliott Williams <e...@apple.com>
Date: 2024-07-29 (Mon, 29 Jul 2024)
Changed paths:
M Source/WTF/wtf/PlatformHave.h
M
Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp
R Source/WebCore/platform/mediastream/mac/CGDisplayStreamCaptureSource.cpp
R Source/WebCore/platform/mediastream/mac/CGDisplayStreamCaptureSource.h
R
Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h
R
Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.mm
M Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp
M Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm
Log Message:
-----------
[WebCore] CGDisplayStream APIs obsoleted in macOS Sequoia
rdar://132608075
https://bugs.webkit.org/show_bug.cgi?id=277189
Reviewed by Eric Carlson.
Starting in the public Sequoia SDK, CGDisplayStream APIs are obsoleted.
WebKit has used ScreenCaptureKit to replace CGDisplayStream for years,
but retains fallback logic which calls into the old API. As of this
year, all supported macOS versions have ScreenCaptureKit, so remove
support entirely.
ScreenCaptureKit is not present in the base system, so it is still
possible for ScreenCaptureKitCaptureSource::isAvailable() to be false.
In place of the fallback logic, add ASSERT_NOT_REACHED and bail out.
* Source/WTF/wtf/PlatformHave.h: Remove the version check for
HAVE(SCREEN_CAPTURE_KIT); all supported releases have it.
Source file deletions:
* Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
(WebCore::DisplayCaptureSourceCocoa::create): Remove fallback.
* Source/WebCore/platform/mediastream/mac/CGDisplayStreamCaptureSource.cpp:
Removed.
* Source/WebCore/platform/mediastream/mac/CGDisplayStreamCaptureSource.h:
Removed.
* Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h:
Removed.
*
Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.mm:
Removed.
* Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:
(WebCore::DisplayCaptureManagerCocoa::screenCaptureDeviceWithPersistentID):
Remove fallback.
* Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm:
(WebKit::DisplayCaptureSessionManager::promptForGetDisplayMedia): Remove
unreachable fallback logic.
Canonical link: https://commits.webkit.org/281529@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
