Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bf7c728f0c7f50f0a0d1be8b14c75b362a8e05f
      
https://github.com/WebKit/WebKit/commit/0bf7c728f0c7f50f0a0d1be8b14c75b362a8e05f
  Author: Alan Baradlay <za...@apple.com>
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
    A LayoutTests/fast/inline/word-spacing-content-wrap-expected.html
    A LayoutTests/fast/inline/word-spacing-content-wrap.html
    M Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M 
Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp
    M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp

  Log Message:
  -----------
  Extra wrap when table and different white-spaces are involved
https://bugs.webkit.org/show_bug.cgi?id=277203
<rdar://problem/132633448>

Reviewed by Antti Koivisto.

word-spacing adds offset at word boundary. This offset needs to be taken into 
account when building the candidate content (input to line breaking).

* LayoutTests/fast/inline/word-spacing-content-wrap-expected.html: Added.
* LayoutTests/fast/inline/word-spacing-content-wrap.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::processInlineContent):
(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::appendToRunList):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::append):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::appendTextContent):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::reset):
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h:
(WebCore::Layout::InlineContentBreaker::ContinuousContent::requiredWidth const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::isHangingContent 
const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::logicalWidth const): 
Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::handleInlineContent):
* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp:
(WebCore::Layout::TextOnlySimpleLineBuilder::commitCandidateContent):
(WebCore::Layout::TextOnlySimpleLineBuilder::handleOverflowingTextContent):

Canonical link: https://commits.webkit.org/281600@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to