Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f91f78d77fdb532f75393779cbb34bf301fcb73b
      
https://github.com/WebKit/WebKit/commit/f91f78d77fdb532f75393779cbb34bf301fcb73b
  Author: Antti Koivisto <[email protected]>
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
    M Source/WebCore/css/process-css-properties.py
    M Source/WebCore/style/ElementRuleCollector.cpp
    M Source/WebCore/style/PropertyCascade.cpp
    M Source/WebCore/style/PropertyCascade.h
    M Source/WebCore/style/StyleBuilder.cpp

  Log Message:
  -----------
  Remove related-property mechanism and rename deferred properties to logical 
group properties
https://bugs.webkit.org/show_bug.cgi?id=277623
rdar://133203218

Reviewed by Tim Nguyen.

The related-property mechanism has no clients left. It is also the only user of
"deferred properties" besides logical group properties. We can now remove this 
confusing
non-spec term from the codebase.

* Source/WebCore/css/process-css-properties.py:
(StylePropertyCodeGenProperties):
(StylePropertyCodeGenProperties.from_json):
(StylePropertyCodeGenProperties.is_logical):
(StyleProperty.perform_fixups_for_longhands):
(StyleProperty.perform_fixups):
(StyleProperties._sort_by_descending_priority_and_name):
(DescriptorCodeGenProperties.__init__):
(GenerateCSSPropertyNames):
(StylePropertyCodeGenProperties.is_deferred): Deleted.
(StyleProperty.perform_fixups_for_related_properties): Deleted.
* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::collectMatchingRulesForList):
* Source/WebCore/style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::buildCascade):
(WebCore::Style::PropertyCascade::set):
(WebCore::Style::PropertyCascade::setLogicalGroupProperty):
(WebCore::Style::PropertyCascade::hasProperty):
(WebCore::Style::PropertyCascade::lastPropertyResolvingLogicalPropertyPair 
const):
(WebCore::Style::PropertyCascade::addMatch):
(WebCore::Style::PropertyCascade::sortLogicalGroupPropertyIDs):
(WebCore::Style::PropertyCascade::setDeferred): Deleted.
(WebCore::Style::PropertyCascade::lastDeferredPropertyResolvingRelated const): 
Deleted.
(WebCore::Style::PropertyCascade::sortDeferredPropertyIDs): Deleted.
* Source/WebCore/style/PropertyCascade.h:
(WebCore::Style::PropertyCascade::isEmpty const):
(WebCore::Style::PropertyCascade::hasNormalProperty const):
(WebCore::Style::PropertyCascade::logicalGroupPropertyIndex const):
(WebCore::Style::PropertyCascade::setLogicalGroupPropertyIndex):
(WebCore::Style::PropertyCascade::hasLogicalGroupProperty const):
(WebCore::Style::PropertyCascade::logicalGroupProperty const):
(WebCore::Style::PropertyCascade::logicalGroupPropertyIDs const):
(WebCore::Style::PropertyCascade::deferredPropertyIndex const): Deleted.
(WebCore::Style::PropertyCascade::setDeferredPropertyIndex): Deleted.
(WebCore::Style::PropertyCascade::hasDeferredProperty const): Deleted.
(WebCore::Style::PropertyCascade::deferredProperty const): Deleted.
(WebCore::Style::PropertyCascade::deferredPropertyIDs const): Deleted.
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::applyDeferredProperties):
(WebCore::Style::Builder::applyProperty):

Canonical link: https://commits.webkit.org/281834@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to