Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dda12ca2d8918d160f77cd179704e14d3845719a
https://github.com/WebKit/WebKit/commit/dda12ca2d8918d160f77cd179704e14d3845719a
Author: Timothy Hatcher <[email protected]>
Date: 2024-08-08 (Thu, 08 Aug 2024)
Changed paths:
M
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm
M Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.h
M Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.mm
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm
Log Message:
-----------
window.open() does not work in a Web Extension popup.
https://webkit.org/b/277728
rdar://133332339
Reviewed by Brian Weinstein.
Hook up `window.open()` to the web extension delegate methods to create a new
window or tab
depending on if the new window delegate method is implemented or not. This
dual-approach is
needed since creating windows is only supported on macOS.
*
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm:
(WebKit::WebExtensionContext::windowsCreate):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(-[_WKWebExtensionActionWebViewDelegate
webView:decidePolicyForNavigationAction:decisionHandler:]): Remove ASSERT
since a new tab is not always guaranteed.
(-[_WKWebExtensionActionWebViewDelegate
webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::canOpenNewWindow const): Added.
(WebKit::WebExtensionContext::openNewWindow): Added.
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, WindowOpenOpensInNewWindow)):
Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIPermissions, AcceptPermissionsRequest)):
Use Util::runScriptWithUserGesture.
(TestWebKitAPI::TEST(WKWebExtensionAPIPermissions, DenyPermissionsRequest)):
Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIPermissions,
AcceptPermissionsDenyMatchPatternsRequest)): Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIPermissions, RequestPermissionsOnly)):
Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIPermissions, RequestMatchPatternsOnly)):
Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIPermissions, GrantOnlySomePermissions)):
Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIPermissions,
GrantOnlySomeMatchPatterns)): Ditto.
(TestWebKitAPI::TEST(WKWebExtensionAPIPermissions, ClipboardWriteWithRequest)):
Ditto.
(TestWebKitAPI::runScriptWithUserGesture): Deleted.
* Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.h: Make new window
delegate method macOS only.
* Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.mm: Ditto.
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(-[TestWebExtensionManager
initForExtension:extensionControllerConfiguration:]): Ditto.
(TestWebKitAPI::Util::runScriptWithUserGesture): Added.
Canonical link: https://commits.webkit.org/281995@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
