Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1f9a7eaf0b2e916b9b2ad6edd4955c35f8b3cebe
https://github.com/WebKit/WebKit/commit/1f9a7eaf0b2e916b9b2ad6edd4955c35f8b3cebe
Author: AlexsanderDamaceno <[email protected]>
Date: 2024-08-09 (Fri, 09 Aug 2024)
Changed paths:
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
M Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp
M Source/WebCore/rendering/TextAutoSizing.cpp
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/style/StyleBuilderCustom.h
Log Message:
-----------
line-height should use LengthType::Normal to represent 'normal'.
https://bugs.webkit.org/show_bug.cgi?id=277249
Reviewed by Tim Nguyen.
The line height computation uses a negative value to represent 'normal' in the
RenderStyle.
Replace negative value check with isNormal() to check if line height is
'normal' as LengthType::Normal was introduced.
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::computeLineHeight const):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::optionalLineHeight):
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::isPreferredLineHeightFontMetricsBased const):
* Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp:
(WebCore::Layout::InlineQuirks::initialLetterAlignmentOffset const):
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::initialSpecifiedLineHeight):
(WebCore::RenderStyle::initialLineHeight):
* Source/WebCore/rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueLineHeight):
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::adjustSelectListButtonStyle):
Canonical link: https://commits.webkit.org/282043@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
