Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: af13e4e2ef6481c4da5794311293cf4679909559
https://github.com/WebKit/WebKit/commit/af13e4e2ef6481c4da5794311293cf4679909559
Author: Alan Baradlay <[email protected]>
Date: 2024-08-11 (Sun, 11 Aug 2024)
Changed paths:
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBlockFlow.h
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderInline.h
M Source/WebCore/rendering/RenderLineBoxList.cpp
M Source/WebCore/rendering/RenderLineBoxList.h
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderTextLineBoxes.cpp
Log Message:
-----------
[Cleanup] Remove unnecessary RenderElement::m_ancestorLineBoxDirty
https://bugs.webkit.org/show_bug.cgi?id=277921
Reviewed by Antti Koivisto.
m_ancestorLineBoxDirty is a leftover from legacy inline layout where it was
used throughout the invalidation code.
Now with svg being the last client of legacy line layout, the only use case for
m_ancestorLineBoxDirty is to optimize
multiple text content changes on a single line when the parent inline box is
empty. -not a common use case at all.
(Also rename dirtyLinesFromChangedChild -> dirtyLineFromChangedChild as there's
never multiple lines for svg content)
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
* Source/WebCore/rendering/RenderElement.h:
(WebCore::RenderElement::dirtyLineFromChangedChild):
(WebCore::RenderElement::dirtyLinesFromChangedChild): Deleted.
(WebCore::RenderElement::ancestorLineBoxDirty const): Deleted.
(WebCore::RenderElement::setAncestorLineBoxDirty): Deleted.
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
* Source/WebCore/rendering/RenderInline.h:
* Source/WebCore/rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLineFromChangedChild):
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild): Deleted.
* Source/WebCore/rendering/RenderLineBoxList.h:
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::clearNeedsLayout):
(WebCore::RenderObject::insertedIntoTree):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::willBeDestroyed):
* Source/WebCore/rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::removeAllFromParent):
(WebCore::RenderTextLineBoxes::dirtyForTextChange):
Canonical link: https://commits.webkit.org/282102@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
