Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 39fa99089cc298573e1a035f10ef661aef8e3b31
https://github.com/WebKit/WebKit/commit/39fa99089cc298573e1a035f10ef661aef8e3b31
Author: Ben Nham <[email protected]>
Date: 2024-08-15 (Thu, 15 Aug 2024)
Changed paths:
M Source/WebCore/page/DeprecatedGlobalSettings.cpp
M Source/WebCore/page/DeprecatedGlobalSettings.h
Log Message:
-----------
Enable BuiltInNotifications by default on iOS
https://bugs.webkit.org/show_bug.cgi?id=277874
rdar://problem/133556912
Reviewed by Brady Eidson.
Just flipping the BuiltInNotifications pref (282148@main) does not work for
enablement because we
read that pref off of DeprecatedGlobalSettings. In UIProcess,
DeprecatedGlobalSettings is not
initialized with the default value of a preference.
We could probably fix this with changes to prefs codegen, but that is a bit
controversial, and also
more than we want to do for enabling this at this point in the release. I went
with a more direct
approach of changing DeprecatedGlobalSettings::builtInNotificationsEnabled
instead.
* Source/WebCore/page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::builtInNotificationsEnabled):
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::builtInNotificationsEnabled): Deleted.
Canonical link: https://commits.webkit.org/282333@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
