Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b982f2ab277ebfcf72ca4cd78b3862e256be1e81
https://github.com/WebKit/WebKit/commit/b982f2ab277ebfcf72ca4cd78b3862e256be1e81
Author: Matt Woodrow <[email protected]>
Date: 2024-09-03 (Tue, 03 Sep 2024)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/mismatched-snapshot-containing-block-size-skips-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/mismatched-snapshot-containing-block-size-skips.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/skip-outbound-vt-before-reveal-expected.txt
M Source/WebCore/html/HTMLLinkElement.cpp
M Source/WebCore/html/HTMLLinkElement.h
Log Message:
-----------
[css-view-transitions-2] mismatched-snapshot-containing-block-size-skips
fails.
https://bugs.webkit.org/show_bug.cgi?id=278759
<rdar://134829177>
Reviewed by Tim Nguyen.
This test largely failed because render blocking for <link rel=stylesheet
blocking=render> wasn't working.
This commit fixes that, making sure we call blockRenderingOn for stylesheet
links. It's somewhat complicated that both rel=stylesheet and rel=expect cause
render blocking, but other don't, and we need to handle mutations correctly.
It refactors the code for blocking in HTMLLinkElement into a single place, and
changes m_blockingList to be instantiated when the attribute is set (the rare
case), rather than when it's queried (the common case).
It also updates test expectations a bit so that there's links to the current
investigations for unfixed failures.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/mismatched-snapshot-containing-block-size-skips-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/skip-outbound-vt-before-reveal-expected.txt:
* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::processInternalResourceLink):
(WebCore::HTMLLinkElement::blockRendering):
(WebCore::HTMLLinkElement::isImplicitlyPotentiallyRenderBlocking const):
(WebCore::HTMLLinkElement::isPotentiallyRenderBlocking const):
(WebCore::HTMLLinkElement::removedFromAncestor):
(WebCore::HTMLLinkElement::setCSSStyleSheet):
* Source/WebCore/html/HTMLLinkElement.h:
Canonical link: https://commits.webkit.org/283119@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
