Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d489dc4fc3730b5fc9c554d02b32ef2828088e4d
      
https://github.com/WebKit/WebKit/commit/d489dc4fc3730b5fc9c554d02b32ef2828088e4d
  Author: Sam Weinig <[email protected]>
  Date:   2024-09-08 (Sun, 08 Sep 2024)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.h
    A Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp
    A Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.h
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/css/process-css-properties.py

  Log Message:
  -----------
  Split align related css property parsing out into its own file
https://bugs.webkit.org/show_bug.cgi?id=279299

Reviewed by Darin Adler.

Splits property consumers for CSS Align properties into their own file and 
refactor
them a bit to hide the implementation details.

We now have explicit functions for each property, named appropriately to match 
the
property. The implementations remain the same, still calling to shared consumers
and passing predicates to refine behavior, but from the outside, things are much
more clear.

The shorthands were also refactored and now all use a shared 
consumeAlignShorthand
consumer function.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
* Source/WebCore/css/parser/CSSPropertyParser.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp: Added.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.h: Added.
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/css/process-css-properties.py:

Canonical link: https://commits.webkit.org/283317@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to