Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bdd3671b9cd09982971306e1e9458425091239fa https://github.com/WebKit/WebKit/commit/bdd3671b9cd09982971306e1e9458425091239fa Author: Sam Weinig <s...@webkit.org> Date: 2024-09-20 (Fri, 20 Sep 2024)
Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/MediaQueryParserContext.cpp M Source/WebCore/css/MediaQueryParserContext.h M Source/WebCore/css/calc/CSSCalcTree+Parser.cpp M Source/WebCore/css/calc/CSSCalcTree+Parser.h M Source/WebCore/css/calc/CSSCalcValue.cpp M Source/WebCore/css/calc/CSSCalcValue.h R Source/WebCore/css/parser/CSSCalcParser.cpp R Source/WebCore/css/parser/CSSCalcParser.h M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParser.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Angle.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Angle.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+AngleDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+ColorInterpolationMethod.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+ColorInterpolationMethod.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Image.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Integer.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Integer.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+IntegerDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthPercentage.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthPercentage.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthPercentageDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaConsumer.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaResolver.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+None.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+NoneDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Number.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Number.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+NumberDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Percentage.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Percentage.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+PercentageDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Resolution.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Resolution.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+ResolutionDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Symbol.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+SymbolDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Time.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Time.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+TimeDefinitions.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+TimingFunction.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Transform.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.h M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.h M Source/WebCore/css/parser/CSSSupportsParser.cpp M Source/WebCore/css/parser/SizesAttributeParser.cpp M Source/WebCore/css/parser/SizesAttributeParser.h M Source/WebCore/css/process-css-properties.py M Source/WebCore/css/query/ContainerQueryParser.cpp M Source/WebCore/css/query/GenericMediaQueryParser.cpp M Source/WebCore/css/query/MediaQueryParser.cpp M Source/WebCore/css/typedom/CSSKeywordValue.cpp M Source/WebCore/css/typedom/CSSNumericValue.cpp M Source/WebCore/css/typedom/CSSNumericValue.h M Source/WebCore/css/typedom/CSSNumericValue.idl M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp M Source/WebCore/css/typedom/StylePropertyMap.cpp M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/html/HTMLLinkElement.cpp Log Message: ----------- Thread CSSParserContext to CSSCalc's parser https://bugs.webkit.org/show_bug.cgi?id=280033 Reviewed by Darin Adler. Threads a CSSParserContext through all numeric primitive CSS value consumers and down into the `calc()` parser. This will allow adoption of CSS Values and Units 5 `calc()` features like `sibling-count()` and `random()` behind a setting. To make things more straightforward, all custom CSS property consumers now always take `CSSParserTokenRange` and `CSSParserContext` as their first two arguments, allowing us to get rid of the special flags "parser-function-requires-context", "parser-function-requires-context" and "parser-function-requires-quirks-mode" from CSSProperties.json. Also to streamline things, CSSCalcParser.h/cpp, which mostly just forwarded to CSSCalcValue, has been removed, with calc() function consuming being moved completely to CSSCalc+Parser.h/cpp. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/MediaQueryParserContext.cpp: * Source/WebCore/css/MediaQueryParserContext.h: * Source/WebCore/css/calc/CSSCalcTree+Parser.cpp: * Source/WebCore/css/calc/CSSCalcTree+Parser.h: * Source/WebCore/css/calc/CSSCalcValue.cpp: * Source/WebCore/css/calc/CSSCalcValue.h: * Source/WebCore/css/parser/CSSCalcParser.cpp: Removed. * Source/WebCore/css/parser/CSSCalcParser.h: Removed. * Source/WebCore/css/parser/CSSParserImpl.cpp: * Source/WebCore/css/parser/CSSPropertyParser.cpp: * Source/WebCore/css/parser/CSSPropertyParser.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Angle.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Angle.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+AngleDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+ColorInterpolationMethod.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+ColorInterpolationMethod.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Image.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Integer.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Integer.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+IntegerDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthPercentage.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthPercentage.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthPercentageDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Lists.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaConsumer.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaResolver.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+None.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+NoneDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Number.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Number.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+NumberDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Percentage.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Percentage.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+PercentageDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Position.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Primitives.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Resolution.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Resolution.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+ResolutionDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Symbol.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+SymbolDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Time.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Time.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+TimeDefinitions.h: * Source/WebCore/css/parser/CSSPropertyParserConsumer+TimingFunction.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+Transform.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.cpp: * Source/WebCore/css/parser/CSSPropertyParserConsumer+ViewTransition.h: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: * Source/WebCore/css/parser/CSSPropertyParserHelpers.h: * Source/WebCore/css/parser/CSSSupportsParser.cpp: * Source/WebCore/css/parser/SizesAttributeParser.cpp: * Source/WebCore/css/parser/SizesAttributeParser.h: * Source/WebCore/css/process-css-properties.py: * Source/WebCore/css/query/ContainerQueryParser.cpp: * Source/WebCore/css/query/GenericMediaQueryParser.cpp: * Source/WebCore/css/query/MediaQueryParser.cpp: * Source/WebCore/css/typedom/CSSKeywordValue.cpp: * Source/WebCore/css/typedom/CSSNumericValue.cpp: * Source/WebCore/css/typedom/CSSNumericValue.h: * Source/WebCore/css/typedom/CSSNumericValue.idl: * Source/WebCore/css/typedom/CSSStyleValueFactory.cpp: * Source/WebCore/css/typedom/StylePropertyMap.cpp: * Source/WebCore/dom/ViewTransition.cpp: * Source/WebCore/html/HTMLLinkElement.cpp: Canonical link: https://commits.webkit.org/284025@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes