Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dda1d973f908e00100021dd7e37936efe9ed36a7
https://github.com/WebKit/WebKit/commit/dda1d973f908e00100021dd7e37936efe9ed36a7
Author: Adrian Perez de Castro <ape...@igalia.com>
Date: 2024-09-23 (Mon, 23 Sep 2024)
Changed paths:
M Tools/Scripts/check-for-invalid-symbols-in-version-script
Log Message:
-----------
[GTK][WPE] check-for-invalid-symbols-in-version-script wrongly matches
hidden symbols
https://bugs.webkit.org/show_bug.cgi?id=280170
Reviewed by Carlos Garcia Campos.
Replace usage of "objdump -t -C", which lists all kinds of symbols,
with "nm -jUCD", which lists only visible symbols from the ELF dynamic
section. This way the tool checks exacrlt against that list, which
always was the intended behaviour.
* Tools/Scripts/check-for-invalid-symbols-in-version-script:
(linker_script_symbols): Renamed from script_symbols to avoid a name
clash, and make the function return a set of strings.
(elf_visible_symbols): Added, runs "nm -jUCD" on the binary and returns
a set of visible symbols exported by the ELF dynamic section.
(script_symbols): Deleted.
Canonical link: https://commits.webkit.org/284063@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
