Branch: refs/heads/webkitglib/2.46
Home: https://github.com/WebKit/WebKit
Commit: bd3f297704b3153be4f530d35279b6c0697f2396
https://github.com/WebKit/WebKit/commit/bd3f297704b3153be4f530d35279b6c0697f2396
Author: Jani Hautakangas <j...@igalia.com>
Date: 2024-09-24 (Tue, 24 Sep 2024)
Changed paths:
M Source/WTF/wtf/unix/UniStdExtrasUnix.cpp
Log Message:
-----------
Cherry-pick 284153@main (bddc4d06811a).
https://bugs.webkit.org/show_bug.cgi?id=280256
[GTK][WPE] IPC::Connection fails to unset FD_CLOEXEC
https://bugs.webkit.org/show_bug.cgi?id=280256
Reviewed by Carlos Garcia Campos.
There's a logic error in UniStdExtrasUnix.cpp where unsetCloseOnExec(int)
expects fnctl(...) F_GETFD to return -1 as a flags value before trying to
remove FD_CLOEXEC flag. However, -1 indicates error so FD_CLOEXEC never gets
removed and calling function in ConnectionUnix createPlatformConnection has
RELEASE_ASSERT which leads to crash.
unsetCloseOnExec should check if fnctl(...) F_GETFD return value is
!= -1 before setting new flag value.
* Source/WTF/wtf/unix/UniStdExtrasUnix.cpp:
(WTF::unsetCloseOnExec):
Canonical link: https://commits.webkit.org/284153@main
Canonical link: https://commits.webkit.org/282416.131@webkitglib/2.46
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
