Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ff192283031ceff6bf50dd3af562d740082a479e
https://github.com/WebKit/WebKit/commit/ff192283031ceff6bf50dd3af562d740082a479e
Author: Jean-Yves Avenard <j...@apple.com>
Date: 2024-09-27 (Fri, 27 Sep 2024)
Changed paths:
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift
Log Message:
-----------
Have dedicated spatial button when watching spatial video
https://bugs.webkit.org/show_bug.cgi?id=280323
rdar://136541301
Reviewed by Jer Noble, Ada Chan, and Aditya Keerthi.
Follow-up on 283297@main where we either showed the button to enter spatial
portal if video had spatial metadata
or docking mode instead.
In this change we will always to display the docking button when in element
fullscreen
and the spatial button will be displayed as necessary at the top/middle of the
video instead.
The docking button will continue to go to docking environment if in element
fullscreen.
Manually tested.
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::fullscreenControllerViewSpatial):
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController showUI]):
(-[WKFullScreenViewController hideUI]):
(-[WKFullScreenViewController
configureEnvironmentPickerOrFullscreenVideoButtonView]):
(-[WKFullScreenViewController _removeEnvironmentFullscreenVideoButtonView]):
(-[WKFullScreenViewController loadView]):
(-[WKFullScreenViewController _createButtonWithExtrinsicContentSize:]):
(-[WKFullScreenViewController _setupButton:]):
* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift:
(SwiftOnlyData.enteredFromInline):
(WKSLinearMediaPlayer.maybeCreateSpatialEntity):
(WKSLinearMediaPlayer.willEnterFullscreen):
(WKSLinearMediaPlayer.didCompleteExitFullscreen(_:any:)):
(WKSLinearMediaPlayer.makeDefaultEntity):
Canonical link: https://commits.webkit.org/284342@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
