Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdd1cb2d251454b026727ba36e3a0c12cc0f08c5 https://github.com/WebKit/WebKit/commit/fdd1cb2d251454b026727ba36e3a0c12cc0f08c5 Author: Daniel Liu <danl...@umich.edu> Date: 2024-09-27 (Fri, 27 Sep 2024)
Changed paths: M Source/JavaScriptCore/heap/BlockDirectory.cpp M Source/JavaScriptCore/heap/BlockDirectory.h M Source/JavaScriptCore/heap/CellContainerInlines.h M Source/JavaScriptCore/heap/HeapInlines.h M Source/JavaScriptCore/heap/MarkedBlock.cpp M Source/JavaScriptCore/heap/MarkedBlock.h M Source/JavaScriptCore/heap/MarkedSpace.cpp M Source/JavaScriptCore/heap/MarkedSpace.h M Source/JavaScriptCore/heap/SlotVisitorInlines.h Log Message: ----------- Add some investigation code for dumping additional info when MarkedBlock::Handle is invalid https://bugs.webkit.org/show_bug.cgi?id=280370 rdar://136782494 Reviewed by Mark Lam and Keith Miller. We want to dump additional information when this failure case is hit to understand why this could be taking place. This patch is an updated version of Yijia's patch, which implemented most of the logging. * Source/JavaScriptCore/heap/BlockDirectory.cpp: (JSC::BlockDirectory::findMarkedBlockHandle): * Source/JavaScriptCore/heap/BlockDirectory.h: * Source/JavaScriptCore/heap/CellContainerInlines.h: (JSC::CellContainer::aboutToMark): * Source/JavaScriptCore/heap/HeapInlines.h: (JSC::Heap::testAndSetMarked): * Source/JavaScriptCore/heap/MarkedBlock.cpp: (JSC::MarkedBlock::aboutToMarkSlow): (JSC::MarkedBlock::dumpInfoIfHandleIsNotValid): * Source/JavaScriptCore/heap/MarkedBlock.h: (JSC::MarkedBlock::Handle::hasBlock): (JSC::MarkedBlock::Header::handleBitsForNullCheck): (JSC::MarkedBlock::aboutToMark): * Source/JavaScriptCore/heap/MarkedSpace.cpp: (JSC::MarkedSpace::findMarkedBlockHandle): * Source/JavaScriptCore/heap/MarkedSpace.h: * Source/JavaScriptCore/heap/SlotVisitorInlines.h: (JSC::SlotVisitor::appendUnbarriered): (JSC::SlotVisitor::appendHiddenUnbarriered): Canonical link: https://commits.webkit.org/284376@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes