Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e4b32fa1e5ad36f902f1f65343186cb47db735c4
https://github.com/WebKit/WebKit/commit/e4b32fa1e5ad36f902f1f65343186cb47db735c4
Author: Antti Koivisto <an...@apple.com>
Date: 2024-10-02 (Wed, 02 Oct 2024)
Changed paths:
A
LayoutTests/fast/css/attribute-selector-for-style-inline-invalidation-expected.html
A LayoutTests/fast/css/attribute-selector-for-style-inline-invalidation.html
M Source/WebCore/dom/StyledElement.cpp
M Source/WebCore/style/StyleScopeRuleSets.cpp
M Source/WebCore/style/StyleScopeRuleSets.h
Log Message:
-----------
rememberthemilk.com: REGRESSION (280692@main): Clicking on the dropdown list
doesn't expand to display its content
https://bugs.webkit.org/show_bug.cgi?id=280787
rdar://136259655
Reviewed by Alan Baradlay.
The page uses attribute selectors that query the value of the style attribute
[style*="display: none;"].b-FS-n { display: block; … }
With the optimization implemented in 280692@main we fail to invalidate
correctly when the
inline style is programmatically mutated, affecting the value of the style
attribute.
*
LayoutTests/fast/css/attribute-selector-for-style-inline-invalidation-expected.html:
Added.
* LayoutTests/fast/css/attribute-selector-for-style-inline-invalidation.html:
Added.
* Source/WebCore/dom/StyledElement.cpp:
(WebCore::StyledElement::dirtyStyleAttribute):
(WebCore::StyledElement::invalidateStyleAttribute):
Uses normal element invalidation instead of optimized inline style one if we
have any selectors targeting style attribute.
* Source/WebCore/style/StyleScopeRuleSets.cpp:
(WebCore::Style::ScopeRuleSets::collectFeatures const):
(WebCore::Style::ScopeRuleSets::selectorsForStyleAttribute const):
Unify the collection of style attribute selector data.
(WebCore::Style::ScopeRuleSets::hasSelectorsForStyleAttribute const): Deleted.
(WebCore::Style::ScopeRuleSets::hasComplexSelectorsForStyleAttribute const):
Deleted.
* Source/WebCore/style/StyleScopeRuleSets.h:
Canonical link: https://commits.webkit.org/284588@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
