Title: [111590] trunk/Source/WebCore
Revision
111590
Author
[email protected]
Date
2012-03-21 12:06:53 -0700 (Wed, 21 Mar 2012)

Log Message

Web audio layout test failed in debug with an ASSERT error in ReverbConvolverStage.cpp
https://bugs.webkit.org/show_bug.cgi?id=81744

Patch by Xingnan Wang <[email protected]> on 2012-03-21
Reviewed by Chris Rogers.

* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (111589 => 111590)


--- trunk/Source/WebCore/ChangeLog	2012-03-21 19:04:30 UTC (rev 111589)
+++ trunk/Source/WebCore/ChangeLog	2012-03-21 19:06:53 UTC (rev 111590)
@@ -1,3 +1,13 @@
+2012-03-21  Xingnan Wang  <[email protected]>
+
+        Web audio layout test failed in debug with an ASSERT error in ReverbConvolverStage.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=81744
+
+        Reviewed by Chris Rogers.
+
+        * platform/audio/ReverbConvolverStage.cpp:
+        (WebCore::ReverbConvolverStage::ReverbConvolverStage):
+
 2012-03-21  Xiaomei Ji  <[email protected]>
 
         [chromium] Font fallback in cr-win is wrong for string contains zero-width-space.

Modified: trunk/Source/WebCore/platform/audio/ReverbConvolverStage.cpp (111589 => 111590)


--- trunk/Source/WebCore/platform/audio/ReverbConvolverStage.cpp	2012-03-21 19:04:30 UTC (rev 111589)
+++ trunk/Source/WebCore/platform/audio/ReverbConvolverStage.cpp	2012-03-21 19:06:53 UTC (rev 111590)
@@ -70,9 +70,11 @@
 
     // But, the FFT convolution itself incurs fftSize / 2 latency, so subtract this out...
     size_t halfSize = fftSize / 2;
-    ASSERT(totalDelay >= halfSize);
-    if (totalDelay >= halfSize)
-        totalDelay -= halfSize;
+    if (!m_directMode) {
+        ASSERT(totalDelay >= halfSize);
+        if (totalDelay >= halfSize)
+            totalDelay -= halfSize;
+    }
 
     // We divide up the total delay, into pre and post delay sections so that we can schedule at exactly the moment when the FFT will happen.
     // This is coordinated with the other stages, so they don't all do their FFTs at the same time...
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to