Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a21d12745b610f640872b85e47e45d6253fc144c
https://github.com/WebKit/WebKit/commit/a21d12745b610f640872b85e47e45d6253fc144c
Author: Philippe Normand <[email protected]>
Date: 2024-10-17 (Thu, 17 Oct 2024)
Changed paths:
M Source/WebCore/page/Page.cpp
M Source/WebCore/platform/mediastream/WebRTCProvider.cpp
M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
Log Message:
-----------
[GStreamer][WebRTC] Rework UDP port ranges support
https://bugs.webkit.org/show_bug.cgi?id=281569
Reviewed by Xabier Rodriguez-Calvar.
This is a follow-up to 285190@main. The WebKit LibWebRTProvider changes in that
revision were
incorrect, the provider doesn't have access to the core page from its
constructor. The correct
approach to apply settings to the provider is to use the
Page::settingsDidChange() method.
Also minPort or maxPort values of 0 are accepted by libwebrtc and mean they are
unspecified, so we
should allow those values.
* Source/WebCore/page/Page.cpp:
(WebCore::Page::settingsDidChange):
* Source/WebCore/platform/mediastream/WebRTCProvider.cpp:
(WebCore::WebRTCProvider::setPortAllocatorRange):
* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_class_init):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCProvider::LibWebRTCProvider):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):
Canonical link: https://commits.webkit.org/285333@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
