Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ae547fbaa071a7b2d64593e90cb71be632ec4333 https://github.com/WebKit/WebKit/commit/ae547fbaa071a7b2d64593e90cb71be632ec4333 Author: Matt Woodrow <mattwood...@apple.com> Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths: A LayoutTests/fast/layers/hidden-scroller-layer-position-crash-expected.txt A LayoutTests/fast/layers/hidden-scroller-layer-position-crash.html M Source/WebCore/rendering/RenderLayerScrollableArea.cpp Log Message: ----------- Twitch.tv ASSERTION FAILED: mode == Verify => !geometryChanged. https://bugs.webkit.org/show_bug.cgi?id=281839 <rdar://138286002> Reviewed by Simon Fraser. Scroll requests are normally handled asynchronously, or their RenderLayers get position updates from an immediate call to updateLayerPositionsAfterOverflowScroll from within RenderLayerScrollableArea::scrollTo. In rare cases neither of those work (overflow:hidden to prevent async, and visibility:hidden to hit an early return RenderLayer::recursiveUpdateLayerPositionsAfterScroll), and the scroll position changes without a layer update. Mark the layer and descendants (their position relative to this layer might have changed) as needing an update. * LayoutTests/fast/layers/hidden-scroller-layer-position-crash-expected.txt: Added. * LayoutTests/fast/layers/hidden-scroller-layer-position-crash.html: Added. * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::scrollTo): Canonical link: https://commits.webkit.org/285549@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes