Title: [111706] trunk/Source/WebCore
- Revision
- 111706
- Author
- ph...@webkit.org
- Date
- 2012-03-22 08:30:26 -0700 (Thu, 22 Mar 2012)
Log Message
[GTK] ASSERT bug in WebAudio (AudioFileReader)
https://bugs.webkit.org/show_bug.cgi?id=81777
Reviewed by Martin Robinson.
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::decodeAudioForBusCreation): Don't steal
the GstBus floating reference.
(WebCore::AudioFileReader::createBus): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (111705 => 111706)
--- trunk/Source/WebCore/ChangeLog 2012-03-22 15:24:26 UTC (rev 111705)
+++ trunk/Source/WebCore/ChangeLog 2012-03-22 15:30:26 UTC (rev 111706)
@@ -1,3 +1,15 @@
+2012-03-22 Philippe Normand <pnorm...@igalia.com>
+
+ [GTK] ASSERT bug in WebAudio (AudioFileReader)
+ https://bugs.webkit.org/show_bug.cgi?id=81777
+
+ Reviewed by Martin Robinson.
+
+ * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
+ (WebCore::AudioFileReader::decodeAudioForBusCreation): Don't steal
+ the GstBus floating reference.
+ (WebCore::AudioFileReader::createBus): Ditto.
+
2012-03-22 Ilya Tikhonovsky <loi...@chromium.org>
Unreviewed: Web Inspector: fix syntax error in text.
Modified: trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp (111705 => 111706)
--- trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp 2012-03-22 15:24:26 UTC (rev 111705)
+++ trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp 2012-03-22 15:30:26 UTC (rev 111706)
@@ -280,7 +280,7 @@
// A deinterleave element is added once a src pad becomes available in decodebin.
m_pipeline = gst_pipeline_new(0);
- GRefPtr<GstBus> bus = adoptGRef(gst_pipeline_get_bus(GST_PIPELINE(m_pipeline)));
+ GRefPtr<GstBus> bus = gst_pipeline_get_bus(GST_PIPELINE(m_pipeline));
gst_bus_add_signal_watch(bus.get());
g_signal_connect(bus.get(), "message", G_CALLBACK(messageCallback), this);
@@ -334,7 +334,7 @@
g_main_loop_run(m_loop.get());
g_main_context_pop_thread_default(context.get());
- GRefPtr<GstBus> bus = adoptGRef(gst_pipeline_get_bus(GST_PIPELINE(m_pipeline)));
+ GRefPtr<GstBus> bus = gst_pipeline_get_bus(GST_PIPELINE(m_pipeline));
g_signal_handlers_disconnect_by_func(bus.get(), reinterpret_cast<gpointer>(messageCallback), this);
g_signal_handlers_disconnect_by_func(m_decodebin.get(), reinterpret_cast<gpointer>(onGStreamerDecodebinPadAddedCallback), this);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
