Title: [111756] trunk
- Revision
- 111756
- Author
- commit-qu...@webkit.org
- Date
- 2012-03-22 13:51:48 -0700 (Thu, 22 Mar 2012)
Log Message
[EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=81512
Source/WebKit/efl:
Add missing implementation markerTextForListItem to EFL's
DumpRenderTreeSupport.
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::markerTextForListItem):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Adding missing implementation markerTextForListItem to EFL's
LayoutTestController so that we can unskip related tests from
the skip list.
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::markerTextForListItem): Implemented.
LayoutTests:
Unskip tests connected with markerTextForListItem().
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (111755 => 111756)
--- trunk/LayoutTests/ChangeLog 2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/LayoutTests/ChangeLog 2012-03-22 20:51:48 UTC (rev 111756)
@@ -1,3 +1,14 @@
+2012-03-22 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+ https://bugs.webkit.org/show_bug.cgi?id=81512
+
+ Unskip tests connected with markerTextForListItem().
+
+ Reviewed by Antonio Gomes.
+
+ * platform/efl/Skipped:
+
2012-03-19 Robert Hogan <rob...@webkit.org>
Text should overflow when list item height set to 0
Modified: trunk/LayoutTests/platform/efl/Skipped (111755 => 111756)
--- trunk/LayoutTests/platform/efl/Skipped 2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-03-22 20:51:48 UTC (rev 111756)
@@ -684,27 +684,6 @@
# EFL's LayoutTestController does not implement callShouldCloseOnWebView
fast/events/onbeforeunload-focused-iframe.html
-# EFL's LayoutTestController does not implement markerTextForListItem
-fast/lists/alpha-boundary-values.html
-fast/lists/alpha-list-wrap.html
-fast/lists/decimal-leading-zero.html
-fast/lists/li-values.html
-fast/lists/list-style-type-dynamic-change.html
-fast/lists/ol-nested-items-dynamic-insert.html
-fast/lists/ol-nested-items-dynamic-remove.html
-fast/lists/ol-nested-items.html
-fast/lists/ol-nested-list-dynamic-insert.html
-fast/lists/ol-nested-list-dynamic-remove.html
-fast/lists/ol-nested-list.html
-fast/lists/positioned-count-crash.html
-fast/lists/w3-css3-list-styles-alphabetic.html
-fast/lists/w3-css3-list-styles-fallback-style.html
-fast/lists/w3-css3-list-styles-numeric.html
-fast/lists/w3-css3-list-styles-symbolic.html
-fast/lists/w3-css3-lower-armenian.html
-fast/lists/w3-css3-upper-armenian.html
-fast/lists/w3-list-styles.html
-
# EFL's LayoutTestController does not implement shadowPseudoId
fullscreen/video-controls-override.html
media/audio-delete-while-step-button-clicked.html
Modified: trunk/Source/WebKit/efl/ChangeLog (111755 => 111756)
--- trunk/Source/WebKit/efl/ChangeLog 2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-03-22 20:51:48 UTC (rev 111756)
@@ -1,5 +1,19 @@
2012-03-22 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+ [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+ https://bugs.webkit.org/show_bug.cgi?id=81512
+
+ Add missing implementation markerTextForListItem to EFL's
+ DumpRenderTreeSupport.
+
+ Reviewed by Antonio Gomes.
+
+ * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+ (DumpRenderTreeSupportEfl::markerTextForListItem):
+ * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
+2012-03-22 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
[EFL] Implement LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=81124
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (111755 => 111756)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-03-22 20:51:48 UTC (rev 111756)
@@ -435,3 +435,13 @@
corePage->settings()->setEditingBehaviorType(coreEditingBehavior);
}
+
+String DumpRenderTreeSupportEfl::markerTextForListItem(JSContextRef context, JSValueRef nodeObject)
+{
+ JSC::ExecState* exec = toJS(context);
+ WebCore::Element* element = WebCore::toElement(toJS(exec, nodeObject));
+ if (!element)
+ return String();
+
+ return WebCore::markerTextForListItem(element);
+}
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (111755 => 111756)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-03-22 20:51:48 UTC (rev 111756)
@@ -82,6 +82,7 @@
static void deliverAllMutationsIfNecessary();
static void setEditingBehavior(Evas_Object* ewkView, const char* editingBehavior);
+ static String markerTextForListItem(JSContextRef, JSValueRef nodeObject);
};
#endif // DumpRenderTreeSupportEfl_h
Modified: trunk/Tools/ChangeLog (111755 => 111756)
--- trunk/Tools/ChangeLog 2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/Tools/ChangeLog 2012-03-22 20:51:48 UTC (rev 111756)
@@ -1,5 +1,19 @@
2012-03-22 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+ [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+ https://bugs.webkit.org/show_bug.cgi?id=81512
+
+ Adding missing implementation markerTextForListItem to EFL's
+ LayoutTestController so that we can unskip related tests from
+ the skip list.
+
+ Reviewed by Antonio Gomes.
+
+ * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+ (LayoutTestController::markerTextForListItem): Implemented.
+
+2012-03-22 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
[EFL] Enable view mode media feature layout tests
https://bugs.webkit.org/show_bug.cgi?id=81205
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (111755 => 111756)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-03-22 20:49:24 UTC (rev 111755)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-03-22 20:51:48 UTC (rev 111756)
@@ -718,10 +718,14 @@
ewk_frame_editable_set(browser->mainFrame(), EINA_TRUE);
}
-JSRetainPtr<JSStringRef> LayoutTestController::markerTextForListItem(JSContextRef, JSValueRef) const
+JSRetainPtr<JSStringRef> LayoutTestController::markerTextForListItem(JSContextRef context, JSValueRef nodeObject) const
{
- notImplemented();
- return 0;
+ String markerTextChar = DumpRenderTreeSupportEfl::markerTextForListItem(context, nodeObject);
+ if (markerTextChar.isEmpty())
+ return 0;
+
+ JSRetainPtr<JSStringRef> markerText(Adopt, JSStringCreateWithUTF8CString(markerTextChar.utf8().data()));
+ return markerText;
}
void LayoutTestController::authenticateSession(JSStringRef, JSStringRef, JSStringRef)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
