Title: [111774] trunk/Source/WebKit/blackberry
- Revision
- 111774
- Author
- commit-qu...@webkit.org
- Date
- 2012-03-22 15:32:54 -0700 (Thu, 22 Mar 2012)
Log Message
[BlackBerry] DeviceDPI Scaling is broken on mobile.
https://bugs.webkit.org/show_bug.cgi?id=81966
Fix our viewport argument handling to only override the
targetDensityDpi on tablet devices. Allow WebCore to use
dpi scaling for smaller screen mobile devices.
Patch by Mike Lattanzio <mlattan...@rim.com> on 2012-03-22
Reviewed by Rob Buis.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (111773 => 111774)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-03-22 22:30:52 UTC (rev 111773)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-03-22 22:32:54 UTC (rev 111774)
@@ -3116,9 +3116,11 @@
int deviceHeight = Platform::Graphics::Screen::primaryScreen()->height();
FloatSize currentPPI = Platform::Graphics::Screen::primaryScreen()->pixelsPerInch(-1);
int deviceDPI = int(roundf((currentPPI.width() + currentPPI.height()) / 2));
- if (m_viewportArguments.targetDensityDpi == ViewportArguments::ValueAuto) {
- // Auto means 160dpi if we leave it alone. This looks terrible for pages wanting 1:1.
- // FIXME: This is insufficient for devices with high dpi, as they will render content unreadably small.
+ if (m_viewportArguments.targetDensityDpi == ViewportArguments::ValueAuto
+ && !Platform::DeviceInfo::instance()->isMobile()) {
+ // If the content provider hasn't specified a target dpi and we have a large
+ // screen we assume the content is fine and set the targetDensityDpi to our dpi.
+ // On smaller screen mobile devices we skip this and use WebCore dpi scaling.
m_viewportArguments.targetDensityDpi = deviceDPI;
}
Modified: trunk/Source/WebKit/blackberry/ChangeLog (111773 => 111774)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-03-22 22:30:52 UTC (rev 111773)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-03-22 22:32:54 UTC (rev 111774)
@@ -1,3 +1,17 @@
+2012-03-22 Mike Lattanzio <mlattan...@rim.com>
+
+ [BlackBerry] DeviceDPI Scaling is broken on mobile.
+ https://bugs.webkit.org/show_bug.cgi?id=81966
+
+ Fix our viewport argument handling to only override the
+ targetDensityDpi on tablet devices. Allow WebCore to use
+ dpi scaling for smaller screen mobile devices.
+
+ Reviewed by Rob Buis.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
+
2012-03-22 Mike Fenton <mifen...@rim.com>
[BlackBerry] Add pattern matching for hexadecimal type input fields
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
