Title: [111859] trunk/Source/WebKit2
- Revision
- 111859
- Author
- [email protected]
- Date
- 2012-03-23 07:25:18 -0700 (Fri, 23 Mar 2012)
Log Message
Unreviewed, rolling out r111855.
http://trac.webkit.org/changeset/111855
https://bugs.webkit.org/show_bug.cgi?id=82053
It broke 30+ tests (Requested by Ossy on #webkit).
Patch by Sheriff Bot <[email protected]> on 2012-03-23
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (111858 => 111859)
--- trunk/Source/WebKit2/ChangeLog 2012-03-23 14:04:41 UTC (rev 111858)
+++ trunk/Source/WebKit2/ChangeLog 2012-03-23 14:25:18 UTC (rev 111859)
@@ -1,3 +1,14 @@
+2012-03-23 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r111855.
+ http://trac.webkit.org/changeset/111855
+ https://bugs.webkit.org/show_bug.cgi?id=82053
+
+ It broke 30+ tests (Requested by Ossy on #webkit).
+
+ * UIProcess/qt/QtPageClient.cpp:
+ (QtPageClient::isViewWindowActive):
+
2012-03-23 Jesus Sanchez-Palencia <[email protected]>
[Qt][WK2] Implement PageClient::isViewWindowActive()
Modified: trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp (111858 => 111859)
--- trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp 2012-03-23 14:04:41 UTC (rev 111858)
+++ trunk/Source/WebKit2/UIProcess/qt/QtPageClient.cpp 2012-03-23 14:25:18 UTC (rev 111859)
@@ -29,7 +29,6 @@
#include "qquickwebview_p.h"
#include "qquickwebview_p_p.h"
#include <QGuiApplication>
-#include <QQuickCanvas>
#include <WebCore/Cursor.h>
#include <WebCore/DragData.h>
#include <WebCore/FloatRect.h>
@@ -256,9 +255,8 @@
bool QtPageClient::isViewWindowActive()
{
- if (!m_webView || !m_webView->canvas())
- return false;
- return m_webView->canvas()->isActive();
+ // FIXME: The scene graph does not have the concept of being active or not when this was written.
+ return true;
}
bool QtPageClient::isViewFocused()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
