Title: [111884] trunk/Source/WebCore
- Revision
- 111884
- Author
- [email protected]
- Date
- 2012-03-23 11:34:31 -0700 (Fri, 23 Mar 2012)
Log Message
<rdar://problem/7883987> ASSERTION FAILED: ASSERT(input == AnimationStateInputEndTimerFired || input == AnimationStateInputPlayStatePaused) in AnimationBase::updateStateMachine causing multiple "crashes" on Lion Intel Debug WebKit testers
https://bugs.webkit.org/show_bug.cgi?id=81351
Rubber-stamped by Jessie Berlin.
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine): Replaced the assertion with a LOG_ERROR so that
the issue is still noticeable, but it does not automatically make the debug bots red.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (111883 => 111884)
--- trunk/Source/WebCore/ChangeLog 2012-03-23 18:30:01 UTC (rev 111883)
+++ trunk/Source/WebCore/ChangeLog 2012-03-23 18:34:31 UTC (rev 111884)
@@ -1,3 +1,14 @@
+2012-03-23 Dan Bernstein <[email protected]>
+
+ <rdar://problem/7883987> ASSERTION FAILED: ASSERT(input == AnimationStateInputEndTimerFired || input == AnimationStateInputPlayStatePaused) in AnimationBase::updateStateMachine causing multiple "crashes" on Lion Intel Debug WebKit testers
+ https://bugs.webkit.org/show_bug.cgi?id=81351
+
+ Rubber-stamped by Jessie Berlin.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine): Replaced the assertion with a LOG_ERROR so that
+ the issue is still noticeable, but it does not automatically make the debug bots red.
+
2012-03-23 Mike Lawther <[email protected]>
CSS3 calc: image sizing works with mixed percentage/absolute
Modified: trunk/Source/WebCore/page/animation/AnimationBase.cpp (111883 => 111884)
--- trunk/Source/WebCore/page/animation/AnimationBase.cpp 2012-03-23 18:30:01 UTC (rev 111883)
+++ trunk/Source/WebCore/page/animation/AnimationBase.cpp 2012-03-23 18:34:31 UTC (rev 111884)
@@ -1494,8 +1494,10 @@
}
break;
case AnimationStateEnding:
- ASSERT(input == AnimationStateInputEndTimerFired || input == AnimationStateInputPlayStatePaused);
-
+#if !LOG_DISABLED
+ if (input != AnimationStateInputEndTimerFired && input != AnimationStateInputPlayStatePaused)
+ LOG_ERROR("State is AnimationStateEnding, but input is not AnimationStateInputEndTimerFired or AnimationStateInputPlayStatePaused. It is %d.", input);
+#endif
if (input == AnimationStateInputEndTimerFired) {
ASSERT(param >= 0);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
