Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3485279ce29b2c912052bff9facdadede856145d
https://github.com/WebKit/WebKit/commit/3485279ce29b2c912052bff9facdadede856145d
Author: Ryosuke Niwa <[email protected]>
Date: 2024-12-18 (Wed, 18 Dec 2024)
Changed paths:
A LayoutTests/fast/shadow-dom/clone-node-in-shadow-tree-crash-expected.txt
A LayoutTests/fast/shadow-dom/clone-node-in-shadow-tree-crash.html
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/Node.h
Log Message:
-----------
REGRESSION(287633@main): Release assert failure in Node::moveTreeToNewScope
https://bugs.webkit.org/show_bug.cgi?id=284863
Reviewed by Chris Dumez.
The release assertion failure was caused by Node::cloneNode erroneously cloning
nodes
using a shadow tree as the tree scope when cloning a node in the shadow tree.
Fixed
the bug by always cloning using the document as the tree scope.
* LayoutTests/fast/shadow-dom/clone-node-in-shadow-tree-crash-expected.txt:
Added.
* LayoutTests/fast/shadow-dom/clone-node-in-shadow-tree-crash.html: Added.
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::cloneNode):
* Source/WebCore/dom/Node.h:
(WebCore::Node::cloneNode): Deleted.
Canonical link: https://commits.webkit.org/288014@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
