Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2e7acfb4a0d55057fcde9267ea01921165a1651b
https://github.com/WebKit/WebKit/commit/2e7acfb4a0d55057fcde9267ea01921165a1651b
Author: Alan Baradlay <[email protected]>
Date: 2024-12-23 (Mon, 23 Dec 2024)
Changed paths:
M
Source/WebCore/layout/integration/LayoutIntegrationFormattingContextLayout.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
Log Message:
-----------
[Cleanup] Rename overridingLogicalHeight/WidthLength to
overridingLogicalHeight/WidthForFlexBasisComputation
https://bugs.webkit.org/show_bug.cgi?id=285091
Reviewed by Antti Koivisto.
"overriding height length" and "overriding height" are easy to confuse and
difficult to determine when to use which.
Let's rename "overriding height length" to "overriding height for flex basis
computation" as that's what it is used for.
RenderBox::computeLogicalWidthInFragment became a slightly more verbose but
it's easier to reason about it.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-flexbox-001.html:
*
Source/WebCore/layout/integration/LayoutIntegrationFormattingContextLayout.cpp:
(WebCore::LayoutIntegration::layoutWithFormattingContextForBox):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::overridingLogicalHeightForFlexBasisComputation const):
(WebCore::RenderBox::setOverridingLogicalHeightForFlexBasisComputation):
(WebCore::RenderBox::clearOverridingLogicalHeightForFlexBasisComputation):
(WebCore::RenderBox::overridingLogicalWidthForFlexBasisComputation const):
(WebCore::RenderBox::setOverridingLogicalWidthForFlexBasisComputation):
(WebCore::RenderBox::clearOverridingLogicalWidthForFlexBasisComputation):
(WebCore::RenderBox::computeLogicalWidthInFragment const):
(WebCore::RenderBox::computeLogicalHeight const):
(WebCore::RenderBox::shouldComputePreferredLogicalWidthsFromStyle const):
(WebCore::RenderBox::overridingLogicalHeightLength const): Deleted.
(WebCore::RenderBox::setOverridingLogicalHeightLength): Deleted.
(WebCore::RenderBox::clearOverridingLogicalHeightLength): Deleted.
(WebCore::RenderBox::overridingLogicalWidthLength const): Deleted.
(WebCore::RenderBox::setOverridingLogicalWidthLength): Deleted.
(WebCore::RenderBox::clearOverridingLogicalWidthLength): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::ScopedFlexBasisAsFlexItemMainSize::ScopedFlexBasisAsFlexItemMainSize):
(WebCore::ScopedFlexBasisAsFlexItemMainSize::~ScopedFlexBasisAsFlexItemMainSize):
Canonical link: https://commits.webkit.org/288246@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
