Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ef2f9a1f717b8a12c7846107d62ba902363c1cac
https://github.com/WebKit/WebKit/commit/ef2f9a1f717b8a12c7846107d62ba902363c1cac
Author: Alan Baradlay <[email protected]>
Date: 2024-12-25 (Wed, 25 Dec 2024)
Changed paths:
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/Position.cpp
M Source/WebCore/editing/VisiblePosition.cpp
M
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp
M Source/WebCore/page/InteractionRegion.cpp
M Source/WebCore/page/TextIndicator.cpp
M Source/WebCore/page/ios/FrameIOS.mm
M Source/WebCore/rendering/CaretRectComputation.cpp
M Source/WebCore/rendering/LegacyInlineIterator.h
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderIFrame.cpp
M Source/WebCore/rendering/RenderIFrame.h
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderObjectInlines.h
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplica.cpp
M Source/WebCore/rendering/line/BreakingContext.h
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
Log Message:
-----------
[Cleanup] Rename RenderObject::isReplacedOrInlineBlock to
isReplacedOrAtomicInline
https://bugs.webkit.org/show_bug.cgi?id=285132
Reviewed by Antti Koivisto.
This bit is set on RenderObject when
1. it is a RenderReplaced (replaced element) -including some fake replaced
renderers like RenderListMarker
2. it is derived from RenderBlock (e.g. RenderGrid, RenderTable,
RenderFlexibleBox etc) and has inline display value (e.g. inline-flex,
inline-block etc)
https://www.w3.org/TR/css-display-3/#atomic-inline
"
atomic inline
An inline-level box that is replaced (such as an image) or that establishes a
new formatting context (such as an inline-block or inline-table) and cannot
split across lines (as inline boxes and ruby containers can).
"
so essentially this flag indicates an either block or inline level replaced box
or and inline level element which is not an inline box.
(There are many cases where we seem to misuse this API, but this rename change
is not meant to fix those)
In this patch isInlineBlockOrInlineTable is also renamed to
isNonReplacedAtomicInline as
this function returns 'false' for all type of renderers except ones derived
from RenderBlock with the inline bit set to true (RenderReplaced renderers are
derived from RenderBox which is not a RenderBlock).
(See RenderBlock's isInlineBlockOrInlineTable { return isInline() &&
isReplacedOrInlineBlock(); })
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::nextContinuation):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::isNonReplacedInline):
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::absoluteBoundingRect):
* Source/WebCore/dom/Position.cpp:
(WebCore::endsOfNodeAreVisuallyDistinctPositions):
* Source/WebCore/editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate const):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate const):
*
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:
(WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox):
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
* Source/WebCore/page/TextIndicator.cpp:
(WebCore::hasNonInlineOrReplacedElements):
* Source/WebCore/page/ios/FrameIOS.mm:
(WebCore::LocalFrame::renderRectForPoint const):
* Source/WebCore/rendering/CaretRectComputation.cpp:
(WebCore::computeCaretRectForBox):
* Source/WebCore/rendering/LegacyInlineIterator.h:
(WebCore::isIteratorTarget):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removePositionedObjectsIfNeeded):
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::paintChild):
(WebCore::RenderBlock::isSelectionRoot const):
(WebCore::RenderBlock::positionForPoint):
(WebCore::RenderBlock::lineHeight const):
(WebCore::RenderBlock::baselinePosition const):
(WebCore::findFirstLetterBlock):
(WebCore::RenderBlock::getFirstLetter):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::simplifiedNormalFlowLayout):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::InlineMinMaxIterator::next):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer const):
(WebCore::RenderBox::computeLogicalWidthInFragment const):
(WebCore::RenderBox::sizesLogicalWidthToFitContent const):
(WebCore::RenderBox::computeLogicalHeight const):
(WebCore::RenderBox::shouldTreatChildAsReplacedInTableCells const):
(WebCore::RenderBox::computePositionedLogicalWidth const):
(WebCore::RenderBox::computePositionedLogicalHeight const):
(WebCore::RenderBox::avoidsFloats const):
(WebCore::RenderBox::isUnsplittableForPagination const):
(WebCore::RenderBox::lineHeight const):
(WebCore::RenderBox::baselinePosition const):
* Source/WebCore/rendering/RenderBox.h:
(WebCore::RenderBox::shouldComputeSizeAsReplaced const):
* Source/WebCore/rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInFragment const):
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::getLeadingCorner const):
(WebCore::RenderElement::getTrailingCorner const):
(WebCore::RenderElement::absoluteAnchorRect const):
(WebCore::RenderElement::createsNewFormattingContext const):
* Source/WebCore/rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::isAtomicInline const): This is odd and iframe should
not override this function.
(WebCore::RenderIFrame::isInlineBlockOrInlineTable const): Deleted.
* Source/WebCore/rendering/RenderIFrame.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::RenderListMarker):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlockForPositionType):
(WebCore::outputRenderTreeLegend):
(WebCore::RenderObject::outputRenderObject const):
(WebCore::RenderObject::caretMaxOffset const):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isAtomicInline const):
(WebCore::RenderObject::hasIntrinsicAspectRatio const):
(WebCore::RenderObject::isReplacedOrAtomicInline const):
(WebCore::RenderObject::setReplacedOrAtomicInline):
(WebCore::RenderObject::isInlineBlockOrInlineTable const): Deleted.
(WebCore::RenderObject::isReplacedOrInlineBlock const): Deleted.
(WebCore::RenderObject::setReplacedOrInlineBlock): Deleted.
* Source/WebCore/rendering/RenderObjectInlines.h:
(WebCore::RenderObject::isAtomicInlineLevelBox const):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::m_intrinsicSize):
* Source/WebCore/rendering/RenderReplica.cpp:
(WebCore::RenderReplica::RenderReplica):
* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::createAnonymousWrappersForInlineContent):
* Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::findParentAndBeforeChildForNonSibling):
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::nextContinuation):
Canonical link: https://commits.webkit.org/288287@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
