Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fc44277cadb8099da5e9a6e8ac4718b622f41b77
https://github.com/WebKit/WebKit/commit/fc44277cadb8099da5e9a6e8ac4718b622f41b77
Author: Elika Etemad <[email protected]>
Date: 2025-01-02 (Thu, 02 Jan 2025)
Changed paths:
M Source/WebCore/rendering/TextBoxPainter.cpp
M Source/WebCore/rendering/TextBoxPainter.h
M Source/WebCore/rendering/TextDecorationPainter.cpp
M Source/WebCore/rendering/TextDecorationPainter.h
Log Message:
-----------
Pass WritingMode, not just isHorizontal, to TextDecorationPainter
https://bugs.webkit.org/show_bug.cgi?id=285223
rdar://problem/142129167
Reviewed by Tim Nguyen and Alan Baradlay.
In order to correctly adjust shadow offsets for all vertical writing modes,
TextDecorationPainter needs to know more than just whether text is horizontal.
Therefore let's give it the WritingMode object rather than a boolean.
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintBackground):
(WebCore::TextBoxPainter::createDecorationPainter):
(WebCore::TextBoxPainter::computePaintRect):
* Source/WebCore/rendering/TextBoxPainter.h:
(WebCore::TextBoxPainter::writingMode const):
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::TextDecorationPainter):
(WebCore::TextDecorationPainter::paintBackgroundDecorations):
* Source/WebCore/rendering/TextDecorationPainter.h:
Canonical link: https://commits.webkit.org/288376@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
