Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e43905574b5307066e3d9c4134a9dad75b04219c
https://github.com/WebKit/WebKit/commit/e43905574b5307066e3d9c4134a9dad75b04219c
Author: Andy Estes <[email protected]>
Date: 2025-01-13 (Mon, 13 Jan 2025)
Changed paths:
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
REGRESSION (287037@main): After calling -[WKWebView
closeAllMediaPresentationsWithCompletionHandler:], subsequent attempts to enter
fullscreen fail
https://bugs.webkit.org/show_bug.cgi?id=285827
rdar://140306400
Reviewed by Chris Dumez.
WebFullScreenManagerProxy::close() is called when a client calls
-[WKWebView closeAllMediaPresentationsWithCompletionHandler:]. After
287037@main, this results in
WebFullScreenManagerProxy::m_client being incorrectly set to null. As a result,
subsequent attempts
to enter fullscreen fail since there is no longer a client when
WebFullScreenManagerProxy::enterFullScreen() is called.
Fixed this by adding WebFullScreenManagerProxy::detachFromClient(). This method
explicitly clears
m_client and is called by WebPageProxy::resetState(). Restored
WebFullScreenManagerProxy::close() to
its previous behavior.
Manually tested.
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::close):
(WebKit::WebFullScreenManagerProxy::detachFromClient):
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetState):
Canonical link: https://commits.webkit.org/288827@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
