Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 49d79a2453dec558b914e4e8ea8158b3adeed431
https://github.com/WebKit/WebKit/commit/49d79a2453dec558b914e4e8ea8158b3adeed431
Author: Alex Christensen <[email protected]>
Date: 2025-01-22 (Wed, 22 Jan 2025)
Changed paths:
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.mm
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h
M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm
M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm
M Source/WebKitLegacy/mac/WebView/WebFrame.mm
Log Message:
-----------
Move AXObjectCache from Document to Page
https://bugs.webkit.org/show_bug.cgi?id=286199
Reviewed by Tyler Wilcock.
There is only one per main Document, which means there is
one per Page anyways. This is preparation for better management
of AXObjectCache in site isolated processes where the main
Frame is a RemoteFrame.
There is one test that covers this with site isolation on
in a case where a Page has no main frame Document,
http/tests/site-isolation/accessibility/hit-test-resolving-remote-frame.html.
To get this test to continue working, I needed to make
WKAccessibilityWebPageObjectBase get the AXObjectCache directly
from the Page instead of the main frame's Document, and I needed
to make accessibilityRootObjectWrapper take an optional LocalFrame
and use the LocalFrame to call AXObjectCache::rootObjectForFrame
instead of AXObjectCache::rootObject.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::createRenderTree):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCacheSlow const):
(WebCore::Document::axObjectCache const):
* Source/WebCore/dom/Document.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::clearAXObjectCache):
(WebCore::Page::axObjectCache):
* Source/WebCore/page/Page.h:
(WebCore::Page::existingAXObjectCache):
Canonical link: https://commits.webkit.org/289258@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
