Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1abf733e45197f18b0ff4de67f9652fee099b021
https://github.com/WebKit/WebKit/commit/1abf733e45197f18b0ff4de67f9652fee099b021
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2025-01-29 (Wed, 29 Jan 2025)
Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
REGRESSION (289535@main): Broke internal macOS downlevel builds
https://bugs.webkit.org/show_bug.cgi?id=286729
rdar://143865562
Unreviewed build fix.
-[PDFDocument resetFormFields:] was introduced in macOS 15. As such,
internal downlevel builds were missing the declaration for this API in
the macOS SDK's PDFDocumentPriv.h header, causing a build failure after
289535@main -- it moved SPI declarations inside !USE_APPLE_INTERNAL_SDK.
To address this build failure, we introduce a PlatformHave macro named
HAVE_PDFDOCUMENT_RESET_FORM_FIELDS, to guard this interface at compile
time.
* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handlePDFActionForAnnotation):
Drive-by cleanup: remove the respondsToSelector: check because
resetFormFields: has long existed in SDK headers of the relevant
platform versions.
Canonical link: https://commits.webkit.org/289543@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
