Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9aa0a838ddc32b4740ccec0cef523204083d841
      
https://github.com/WebKit/WebKit/commit/b9aa0a838ddc32b4740ccec0cef523204083d841
  Author: Brianna Fan <bf...@apple.com>
  Date:   2025-02-14 (Fri, 14 Feb 2025)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [Static Analyzer CI] Refactor FindUnexpectedStaticAnalyzerResults to be more 
modular and understandable
https://bugs.webkit.org/show_bug.cgi?id=287184
rdar://144336563

Reviewed by Aakash Jain.

Separate logic into FindUnexpectedStaticAnalyzerResults and 
FindUnexpectedStaticAnalyzerResultsWithoutChange.
This removes the need for the confusing `use_expectations` argument.

* Tools/CISupport/ews-build/steps.py:
(ScanBuild.addResultsSteps):
(ScanBuildWithoutChange.addResultsSteps):
(FindUnexpectedStaticAnalyzerResults.__init__): Remove use_expectations.
(FindUnexpectedStaticAnalyzerResults.run): Remove logic that will be used in 
WithoutChange.
(FindUnexpectedStaticAnalyzerResults.decode_results_data): Added. To be reused 
in multiple locations.
(FindUnexpectedStaticAnalyzerResults.filter_results_using_results_db): Use 
decode_results_data.

(FindUnexpectedStaticAnalyzerResultsWithoutChange): Move all the logic for the 
second run here.
(FindUnexpectedStaticAnalyzerResultsWithoutChange.run):

* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/290412@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to