Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6171cf70d4c93b06842dfd5ccce51ed185c24c2a
https://github.com/WebKit/WebKit/commit/6171cf70d4c93b06842dfd5ccce51ed185c24c2a
Author: Per Arne Vollan <[email protected]>
Date: 2025-02-20 (Thu, 20 Feb 2025)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
Log Message:
-----------
TestWebKitAPI.WKDownload tests are failing
https://bugs.webkit.org/show_bug.cgi?id=287992
rdar://145101077
Reviewed by Basuke Suzuki.
When Modern DownloadProgress is enabled, an extra delegate callback,
DecidePlaceholderPolicy, is being called
after the DecideDestination callback. This patch resolves test failures by
adding this callback to the list
of expected callbacks. Since it is no longer possible to toggle the Modern
DownloadProgress feature on and
off with a preference, this patch also deletes a test that relies on disabling
the feature. This patch does
not address an issue observed where an unhandled exception is being thrown in
the Networking process, since
it has a different root cause.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TestWebKitAPI::FinishSuccessfully)):
(TestWebKitAPI::CancelAndResume)):
(TestWebKitAPI::FailAndResume)):
(TestWebKitAPI::CancelNoResumeData)):
(TestWebKitAPI::FailNoResumeData)):
(TestWebKitAPI::ResumeAfterZeroBytesReceived)):
(TestWebKitAPI::mutateFile):
(TestWebKitAPI::ResumeCantReconnect)):
(TestWebKitAPI::UnknownContentLength)):
(TestWebKitAPI::InvalidArguments)):
(TestWebKitAPI::RedirectAllow)):
(TestWebKitAPI::DownloadRequest404)):
(TestWebKitAPI::NetworkProcessCrash)):
(TestWebKitAPI::SuggestedFilenameFromHost)):
(TestWebKitAPI::PathMustExist)):
(TestWebKitAPI::FileMustNotExist)):
(TestWebKitAPI::DestinationNullString)):
(TestWebKitAPI::ChallengeSuccess)):
(TestWebKitAPI::BlobResponse)):
(TestWebKitAPI::BlobResponseNoFilename)):
(TestWebKitAPI::SubframeOriginator)):
(TestWebKitAPI::LockdownModePDF)):
(TestWebKitAPI::LockdownModeUSDZ)):
Canonical link: https://commits.webkit.org/290732@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
