Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ad88eda031ef549d0115563839afbbee931d8368
https://github.com/WebKit/WebKit/commit/ad88eda031ef549d0115563839afbbee931d8368
Author: Mike Wyrzykowski <[email protected]>
Date: 2025-03-03 (Mon, 03 Mar 2025)
Changed paths:
A LayoutTests/fast/webgpu/regression/repro_1382-expected.txt
A LayoutTests/fast/webgpu/regression/repro_1382.html
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/Device.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
Log Message:
-----------
[WebGPU] Index buffer validation is incorrect in indirect path on Intel Macs
https://bugs.webkit.org/show_bug.cgi?id=288945
rdar://145838189
Reviewed by Dan Glastonbury.
Intel / AMD doesn't support VS - VS memory barriers and we usually split the
pass,
but in the case of drawIndexedIndirect the validation is two stages and uses
the output of the first stage as the input of the second.
So we do not cause an OOB read, manually clamp in the second stage.
* LayoutTests/fast/webgpu/regression/repro_1382-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_1382.html: Added.
Add regression test.
* Source/WebGPU/WebGPU/Buffer.h:
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Buffer::indirectBufferRequiresRecomputation const):
(WebGPU::Buffer::indirectIndexedBufferRequiresRecomputation const):
(WebGPU::Buffer::indirectBufferRecomputed):
(WebGPU::Buffer::indirectIndexedBufferRecomputed):
* Source/WebGPU/WebGPU/Device.mm:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::clampIndexBufferToValidValues):
(WebGPU::RenderPassEncoder::clampIndirectIndexBufferToValidValues):
(WebGPU::verticesPerPrimitive):
(WebGPU::RenderPassEncoder::drawIndexed):
(WebGPU::RenderPassEncoder::drawIndexedIndirect):
Clamp values in indirect indexed path.
Canonical link: https://commits.webkit.org/291525@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
